fix paddleOCR size issue #775
Conversation
| return new int[] {h32 * 32, w32 * 32}; | ||
| int w32 = Math.max((int) w / 32 / h32, 1); | ||
| // height must be 32 (fixed) | ||
| return new int[] {32, w32 * 32}; |
There was a problem hiding this comment.
if height is fixed to 32, shouldn't the algorithm be just w = 32 / h * w ?
There was a problem hiding this comment.
We still need to make sure width are base 32 number and has proper aspect ratio
There was a problem hiding this comment.
Does this work:
int ratio = Math.floorDiv(w, h);
There was a problem hiding this comment.
No, this doesn't apply here.
There was a problem hiding this comment.
floorDiv cannot be used on floating number
There was a problem hiding this comment.
As Jake pointed out, if you height is always 32, the width should simply be 32 * ratio,
no need to test if size is less then 32 or not. the whole function can be:
int ratio = Math.max((int) w / h, 1);
return new int[] {32, 32 * ratio};
There was a problem hiding this comment.
I tried this way, the last inference result is always wrong. Will try this implementAction again.
| int w32 = (int) w / 32; | ||
| return new int[] {h32 * 32, w32 * 32}; | ||
| private int[] resize32(double w) { | ||
| int width = ((int) Math.max(32, w)) / 32 * 32; |
There was a problem hiding this comment.
This is not correct. This basically keep the original width and removed the remainder.
There was a problem hiding this comment.
No, it trimmed the width to a 32 based number. The apect ratio didn't help on the inference result
There was a problem hiding this comment.
this is weird, Can you add a comments here?
Description
The word recognition OCR model from PaddlePaddle require height to be fixed 32 or an error will be thrown.